Commit 4afa0c22 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Greg Kroah-Hartman
Browse files

driver core: auxiliary bus: Fix memory leak when driver_register() fail 



If driver_register() returns with error we need to free the memory
allocated for auxdrv->driver.name before returning from
__auxiliary_driver_register()

Fixes: 7de3697e ("Add auxiliary bus support")
Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20210713093438.3173-1-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2734d6c1

drivers/base/auxiliary.c

+7 −1
Original line number Diff line number Diff line
@@ -231,6 +231,8 @@ EXPORT_SYMBOL_GPL(auxiliary_find_device); 
int __auxiliary_driver_register(struct auxiliary_driver *auxdrv,

				struct module *owner, const char *modname)

{

	int ret;



	if (WARN_ON(!auxdrv->probe) || WARN_ON(!auxdrv->id_table))

		return -EINVAL;
@@ -246,7 +248,11 @@ int __auxiliary_driver_register(struct auxiliary_driver *auxdrv, 
	auxdrv->driver.bus = &auxiliary_bus_type;

	auxdrv->driver.mod_name = modname;



	return driver_register(&auxdrv->driver);

	ret = driver_register(&auxdrv->driver);

	if (ret)

		kfree(auxdrv->driver.name);



	return ret;

}

EXPORT_SYMBOL_GPL(__auxiliary_driver_register);