Commit e4163fc5 authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Alexandre Belloni
Browse files

rtc: pcf2127: add error checking when disabling POR0 



If PCF2127 device is absent from the I2C bus, or if there is a
communication problem, disabling POR0 may fail silently and we
still continue with probing the device. In that case, abort probe
operation.

Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20230728171211.3016019-1-hugo@hugovil.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 4e5eb7ef

drivers/rtc/rtc-pcf2127.c

+3 −1
Original line number Diff line number Diff line
@@ -1192,8 +1192,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, 
	 * The "Power-On Reset Override" facility prevents the RTC to do a reset

	 * after power on. For normal operation the PORO must be disabled.

	 */

	regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1,

	ret = regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1,

				PCF2127_BIT_CTRL1_POR_OVRD);

	if (ret < 0)

		return ret;



	ret = regmap_read(pcf2127->regmap, pcf2127->cfg->reg_clkout, &val);

	if (ret < 0)