Commit 4e5eb7ef authored by Dan Carpenter's avatar Dan Carpenter Committed by Alexandre Belloni
Browse files

rtc: pcf2127: fix error code in pcf2127_enable_ts() 



This error path accidentally returns success.  Return -EINVAL instead.

Fixes: 420cc9e8 ("rtc: pcf2127: add support for multiple TS functions")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarBruno Thomsen <bruno.thomsen@gmail.com>
Reviewed-by: default avatarHugo Villeneuve <hugo@hugovil.com>
Reviewed-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/55b9c84b-9d21-444f-b91a-cf9316b65833@moroto.mountain


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent d890cfc2

drivers/rtc/rtc-pcf2127.c

+1 −1
Original line number Diff line number Diff line
@@ -1060,7 +1060,7 @@ static int pcf2127_enable_ts(struct device *dev, int ts_id) 
	if (pcf2127->cfg->ts[ts_id].gnd_detect_bit == 0) {

		dev_err(dev, "%s: tamper detection to GND configuration invalid\n",

			__func__);

		return ret;

		return -EINVAL;

	}



	/*