Unverified Commit e2368933 authored by Barry Song's avatar Barry Song Committed by Mark Brown
Browse files

spi: spi-stm32: remove redundant irqsave and irqrestore in hardIRQ 



Running in hardIRQ, disabling IRQ is redundant.

Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200926001616.21292-2-song.bao.hua@hisilicon.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 69544f2c

drivers/spi/spi-stm32.c

+4 −5
Original line number Diff line number Diff line
@@ -804,10 +804,9 @@ static irqreturn_t stm32f4_spi_irq_event(int irq, void *dev_id) 
	struct spi_master *master = dev_id;

	struct stm32_spi *spi = spi_master_get_devdata(master);

	u32 sr, mask = 0;

	unsigned long flags;

	bool end = false;



	spin_lock_irqsave(&spi->lock, flags);

	spin_lock(&spi->lock);



	sr = readl_relaxed(spi->base + STM32F4_SPI_SR);

	/*
@@ -833,7 +832,7 @@ static irqreturn_t stm32f4_spi_irq_event(int irq, void *dev_id) 


	if (!(sr & mask)) {

		dev_dbg(spi->dev, "spurious IT (sr=0x%08x)\n", sr);

		spin_unlock_irqrestore(&spi->lock, flags);

		spin_unlock(&spi->lock);

		return IRQ_NONE;

	}
@@ -875,11 +874,11 @@ static irqreturn_t stm32f4_spi_irq_event(int irq, void *dev_id) 
					STM32F4_SPI_CR2_TXEIE |

					STM32F4_SPI_CR2_RXNEIE |

					STM32F4_SPI_CR2_ERRIE);

		spin_unlock_irqrestore(&spi->lock, flags);

		spin_unlock(&spi->lock);

		return IRQ_WAKE_THREAD;

	}



	spin_unlock_irqrestore(&spi->lock, flags);

	spin_unlock(&spi->lock);

	return IRQ_HANDLED;

}