Unverified Commit 69544f2c authored by Barry Song's avatar Barry Song Committed by Mark Brown
Browse files

spi: spi-tegra20-sflash: remove redundant irqsave and irqrestore in hardIRQ 



Running in hardIRQ, disabling IRQ is redundant.

Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200926001616.21292-1-song.bao.hua@hisilicon.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 23f370c7

drivers/spi/spi-tegra20-sflash.c

+2 −3
Original line number Diff line number Diff line
@@ -359,9 +359,8 @@ static int tegra_sflash_transfer_one_message(struct spi_master *master, 
static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd)

{

	struct spi_transfer *t = tsd->curr_xfer;

	unsigned long flags;



	spin_lock_irqsave(&tsd->lock, flags);

	spin_lock(&tsd->lock);

	if (tsd->tx_status || tsd->rx_status || (tsd->status_reg & SPI_BSY)) {

		dev_err(tsd->dev,

			"CpuXfer ERROR bit set 0x%x\n", tsd->status_reg);
@@ -391,7 +390,7 @@ static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd) 
	tegra_sflash_calculate_curr_xfer_param(tsd->cur_spi, tsd, t);

	tegra_sflash_start_cpu_based_transfer(tsd, t);

exit:

	spin_unlock_irqrestore(&tsd->lock, flags);

	spin_unlock(&tsd->lock);

	return IRQ_HANDLED;

}