Commit e0b27d38 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: phy: generic: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220922133323.2135494-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5d5fb7c7

drivers/usb/phy/phy-generic.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -230,12 +230,9 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop) 
		err = PTR_ERR_OR_ZERO(nop->gpiod_vbus);

		err = PTR_ERR_OR_ZERO(nop->gpiod_vbus);

	}

	}





	if (err == -EPROBE_DEFER)

	if (err)

		return -EPROBE_DEFER;

		return dev_err_probe(dev, err,

	if (err) {

				     "Error requesting RESET or VBUS GPIO\n");

		dev_err(dev, "Error requesting RESET or VBUS GPIO\n");

		return err;

	}

	if (nop->gpiod_reset)

	if (nop->gpiod_reset)

		gpiod_direction_output(nop->gpiod_reset, 1);

		gpiod_direction_output(nop->gpiod_reset, 1);