Commit 5d5fb7c7 authored by Liu Shixin's avatar Liu Shixin Committed by Greg Kroah-Hartman
Browse files

usb: ulpi: use DEFINE_SHOW_ATTRIBUTE to simplify ulpi_regs 



Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.

Signed-off-by: default avatarLiu Shixin <liushixin2@huawei.com>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220922142505.3248167-1-liushixin2@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29afbe5f

drivers/usb/common/ulpi.c

+3 −17
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static int ulpi_read_id(struct ulpi *ulpi) 
	return 0;

}



static int ulpi_regs_read(struct seq_file *seq, void *data)

static int ulpi_regs_show(struct seq_file *seq, void *data)

{

	struct ulpi *ulpi = seq->private;
@@ -269,21 +269,7 @@ static int ulpi_regs_read(struct seq_file *seq, void *data) 


	return 0;

}



static int ulpi_regs_open(struct inode *inode, struct file *f)

{

	struct ulpi *ulpi = inode->i_private;



	return single_open(f, ulpi_regs_read, ulpi);

}



static const struct file_operations ulpi_regs_ops = {

	.owner = THIS_MODULE,

	.open = ulpi_regs_open,

	.release = single_release,

	.read = seq_read,

	.llseek = seq_lseek

};

DEFINE_SHOW_ATTRIBUTE(ulpi_regs);



#define ULPI_ROOT debugfs_lookup(KBUILD_MODNAME, NULL)
@@ -316,7 +302,7 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi) 
	}



	root = debugfs_create_dir(dev_name(dev), ULPI_ROOT);

	debugfs_create_file("regs", 0444, root, ulpi, &ulpi_regs_ops);

	debugfs_create_file("regs", 0444, root, ulpi, &ulpi_regs_fops);



	dev_dbg(&ulpi->dev, "registered ULPI PHY: vendor %04x, product %04x\n",

		ulpi->id.vendor, ulpi->id.product);