Commit de1eaf60 authored by Baruch Siach's avatar Baruch Siach Committed by Bartosz Golaszewski
Browse files

gpio: mvebu: make pwm .get_state closer to idempotent 



Round up the divisions in .get_state() to make applying the read out
configuration idempotent in most cases as .apply rounds down.

Reported-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent aa37e27f

drivers/gpio/gpio-mvebu.c

+2 −2
Original line number Diff line number Diff line
@@ -668,7 +668,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, 


	regmap_read(mvpwm->regs, mvebu_pwmreg_blink_on_duration(mvpwm), &u);

	val = (unsigned long long) u * NSEC_PER_SEC;

	do_div(val, mvpwm->clk_rate);

	val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);

	if (val > UINT_MAX)

		state->duty_cycle = UINT_MAX;

	else if (val)
@@ -680,7 +680,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, 
	regmap_read(mvpwm->regs, mvebu_pwmreg_blink_off_duration(mvpwm), &u);

	val += (unsigned long long) u; /* period = on + off duration */

	val *= NSEC_PER_SEC;

	do_div(val, mvpwm->clk_rate);

	val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);

	if (val > UINT_MAX)

		state->period = UINT_MAX;

	else if (val)