Commit dcab596f authored by Shang XiaoJing's avatar Shang XiaoJing Committed by Lipeng Sang
Browse files

nfc: nfcmrvl: Fix potential memory leak in nfcmrvl_i2c_nci_send()

stable inclusion
from stable-v5.10.154
commit 52438e734c1566f5e2bcd9a065d2d65e306c0555
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I64YCB

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=52438e734c1566f5e2bcd9a065d2d65e306c0555



--------------------------------

[ Upstream commit 93d904a7 ]

nfcmrvl_i2c_nci_send() will be called by nfcmrvl_nci_send(), and skb
should be freed in nfcmrvl_i2c_nci_send(). However, nfcmrvl_nci_send()
will only free skb when i2c_master_send() return >=0, which means skb
will memleak when i2c_master_send() failed. Free skb no matter whether
i2c_master_send() succeeds.

Fixes: b5b3e23e ("NFC: nfcmrvl: add i2c driver")
Signed-off-by: default avatarShang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLipeng Sang <sanglipeng1@jd.com>
parent 53b15821
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment