Commit dbbd49ba authored by Pali Rohár's avatar Pali Rohár Committed by Viresh Kumar
Browse files

cpufreq: armada-37xx: Fix module unloading 



This driver is missing module_exit hook. Add proper driver exit function
which unregisters the platform device and cleans up the data.

Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Tested-by: default avatarTomasz Maciej Nowak <tmn505@gmail.com>
Tested-by: default avatarAnders Trier Olesen <anders.trier.olesen@gmail.com>
Tested-by: default avatarPhilip Soares <philips@netisense.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 5f23eb9d

drivers/cpufreq/armada-37xx-cpufreq.c

+25 −0
Original line number Diff line number Diff line
@@ -86,6 +86,8 @@ static int avs_map[] = { 
};



struct armada37xx_cpufreq_state {

	struct platform_device *pdev;

	struct device *cpu_dev;

	struct regmap *regmap;

	u32 nb_l0l1;

	u32 nb_l2l3;
@@ -506,6 +508,9 @@ static int __init armada37xx_cpufreq_driver_init(void) 
	if (ret)

		goto disable_dvfs;



	armada37xx_cpufreq_state->cpu_dev = cpu_dev;

	armada37xx_cpufreq_state->pdev = pdev;

	platform_set_drvdata(pdev, dvfs);

	return 0;



disable_dvfs:
@@ -524,6 +529,26 @@ static int __init armada37xx_cpufreq_driver_init(void) 
/* late_initcall, to guarantee the driver is loaded after A37xx clock driver */

late_initcall(armada37xx_cpufreq_driver_init);



static void __exit armada37xx_cpufreq_driver_exit(void)

{

	struct platform_device *pdev = armada37xx_cpufreq_state->pdev;

	struct armada_37xx_dvfs *dvfs = platform_get_drvdata(pdev);

	unsigned long freq;

	int load_lvl;



	platform_device_unregister(pdev);



	armada37xx_cpufreq_disable_dvfs(armada37xx_cpufreq_state->regmap);



	for (load_lvl = ARMADA_37XX_DVFS_LOAD_0; load_lvl < LOAD_LEVEL_NR; load_lvl++) {

		freq = dvfs->cpu_freq_max / dvfs->divider[load_lvl];

		dev_pm_opp_remove(armada37xx_cpufreq_state->cpu_dev, freq);

	}



	kfree(armada37xx_cpufreq_state);

}

module_exit(armada37xx_cpufreq_driver_exit);



static const struct of_device_id __maybe_unused armada37xx_cpufreq_of_match[] = {

	{ .compatible = "marvell,armada-3700-nb-pm" },

	{ },