Commit da0dea89 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: spear: Free resources only after pwmchip_remove() 



Before pwmchip_remove() returns the PWM is expected to be functional. So
remove the pwmchip before disabling the clocks. The check for
pwmchip_remove()'s return value is dropped as this function returns
effectively always 0 and returning an error in a remove callback is
useless anyhow (as the device core ignores it and drops devm allocated
resources).

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent b601a18f

drivers/pwm/pwm-spear.c

+4 −1
Original line number Diff line number Diff line
@@ -229,9 +229,12 @@ static int spear_pwm_remove(struct platform_device *pdev) 
{

	struct spear_pwm_chip *pc = platform_get_drvdata(pdev);



	pwmchip_remove(&pc->chip);



	/* clk was prepared in probe, hence unprepare it here */

	clk_unprepare(pc->clk);

	return pwmchip_remove(&pc->chip);



	return 0;

}



static const struct of_device_id spear_pwm_of_match[] = {