Commit b601a18f authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: spear: Don't modify HW state in .remove callback 



A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

So drop the hardware modification from the .remove() callback.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 937efa29

drivers/pwm/pwm-spear.c

+0 −4
Original line number Diff line number Diff line
@@ -228,10 +228,6 @@ static int spear_pwm_probe(struct platform_device *pdev) 
static int spear_pwm_remove(struct platform_device *pdev)

{

	struct spear_pwm_chip *pc = platform_get_drvdata(pdev);

	int i;



	for (i = 0; i < NUM_PWM; i++)

		pwm_disable(&pc->chip.pwms[i]);



	/* clk was prepared in probe, hence unprepare it here */

	clk_unprepare(pc->clk);