Commit d792a7a9 authored by Ameer Hamza's avatar Ameer Hamza Committed by Arnaldo Carvalho de Melo
Browse files

perf session: Check for NULL pointer before dereference 



Move NULL pointer check before dereferencing the variable.

Addresses-Coverity: 1497622 ("Derereference before null check")
Reviewed-by: default avatarJames Clark <james.clark@arm.com>
Signed-off-by: default avatarAmeer Hamza <amhamza.mgc@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Link: https://lore.kernel.org/r/20220125121141.18347-1-amhamza.mgc@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a663520f

tools/perf/util/session.c

+2 −1
Original line number Diff line number Diff line
@@ -1503,11 +1503,12 @@ static int machines__deliver_event(struct machines *machines, 
			++evlist->stats.nr_unknown_id;

			return 0;

		}

		dump_sample(evsel, event, sample, perf_env__arch(machine->env));

		if (machine == NULL) {

			++evlist->stats.nr_unprocessable_samples;

			dump_sample(evsel, event, sample, perf_env__arch(NULL));

			return 0;

		}

		dump_sample(evsel, event, sample, perf_env__arch(machine->env));

		return evlist__deliver_sample(evlist, tool, event, sample, evsel, machine);

	case PERF_RECORD_MMAP:

		return tool->mmap(tool, event, sample, machine);