Commit a663520f authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Set error stream of objdump process for TUI 



The stderr should be set to a pipe when using TUI.  Otherwise it'd
print to stdout and break TUI windows with an error message.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220202070828.143303-2-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ae65b443

tools/perf/util/annotate.c

+1 −0
Original line number Diff line number Diff line
@@ -2036,6 +2036,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) 
	memset(&objdump_process, 0, sizeof(objdump_process));

	objdump_process.argv = objdump_argv;

	objdump_process.out = -1;

	objdump_process.err = -1;

	if (start_command(&objdump_process)) {

		pr_err("Failure starting to run %s\n", command);

		err = -1;