Commit d713b8d2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: uninitialized variable in amd_pmc_s2d_init() 



The "size" variable can be uninitialized if amd_pmc_send_cmd() fails.

Fixes: 3d7d407d ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220307141832.GA19660@kili


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent f2a6c7e7

drivers/platform/x86/amd-pmc.c

+2 −1
Original line number Diff line number Diff line
@@ -708,8 +708,9 @@ static const struct pci_device_id pmc_pci_ids[] = { 


static int amd_pmc_s2d_init(struct amd_pmc_dev *dev)

{

	u32 size, phys_addr_low, phys_addr_hi;

	u32 phys_addr_low, phys_addr_hi;

	u64 stb_phys_addr;

	u32 size = 0;



	/* Spill to DRAM feature uses separate SMU message port */

	dev->msg_port = 1;