Commit f2a6c7e7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

platform/x86: intel-uncore-freq: fix uncore_freq_common_init() error codes 



Currently the uncore_freq_common_init() return one on success and
zero on failure.  There is only one caller and it has a "forgot to set
the error code" bug.  Change uncore_freq_common_init() to return
negative error codes which makes the code simpler and avoids this kind
of bug in the future.

Fixes: dbce412a ("platform/x86/intel-uncore-freq: Split common and enumeration part")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://lore.kernel.org/r/20220304131925.GG28739@kili


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent c91a5b1c

drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c

+1 −1
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ int uncore_freq_common_init(int (*read_control_freq)(struct uncore_data *data, u 
		++uncore_instance_count;

	mutex_unlock(&uncore_lock);



	return (!!uncore_root_kobj);

	return uncore_root_kobj ? 0 : -ENOMEM;

}

EXPORT_SYMBOL_NS_GPL(uncore_freq_common_init, INTEL_UNCORE_FREQUENCY);

drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c

+1 −1
Original line number Diff line number Diff line
@@ -225,7 +225,7 @@ static int __init intel_uncore_init(void) 


	ret = uncore_freq_common_init(uncore_read_control_freq, uncore_write_control_freq,

				      uncore_read_freq);

	if (!ret)

	if (ret)

		goto err_free;



	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,