Unverified Commit d50d7e91 authored Mar 24, 2022 by Jakob Koschel Committed by Mark Brown Apr 05, 2022

spi: spidev: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/


Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324072534.63420-1-jakobkoschel@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 02b30248

drivers/spi/spidev.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -568,19 +568,20 @@ spidev_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

		static int spidev_open(struct inode inode, struct file filp)
		{
		struct spidev_data *spidev;
		struct spidev_data spidev = NULL, iter;
		int status = -ENXIO;

		mutex_lock(&device_list_lock);

		list_for_each_entry(spidev, &device_list, device_entry) {
		if (spidev->devt == inode->i_rdev) {
		list_for_each_entry(iter, &device_list, device_entry) {
		if (iter->devt == inode->i_rdev) {
		status = 0;
		spidev = iter;
		break;
		}
		}

		if (status) {
		if (!spidev) {
		pr_debug("spidev: nothing for minor %d\n", iminor(inode));
		goto err_find_dev;
		}