Commit d4b2d19d authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Silence the overflow warning while building offset mask 

Coverity reports "Potentially overflowing expression ..." warning, which
is correct thing to complain from the compiler point of view, but this is
not possible in the current code. Still, this is a small error as there
are some future situations that might need to use a 32 bit offset. Use ULL
so the calculation works up to 63.

Fixes: b045db62 ("RDMA/mlx5: Use ib_umem_find_best_pgoff() for SRQ")
Link: https://lore.kernel.org/r/20201125061704.6580-1-leon@kernel.org


Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent d0b7721c

drivers/infiniband/hw/mlx5/mem.c

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ unsigned long __mlx5_umem_find_best_quantized_pgoff( 
	unsigned int page_offset_bits, u64 pgoff_bitmask, unsigned int scale,

	unsigned int *page_offset_quantized)

{

	const u64 page_offset_mask = (1 << page_offset_bits) - 1;

	const u64 page_offset_mask = (1UL << page_offset_bits) - 1;

	unsigned long page_size;

	u64 page_offset;