Commit d0b7721c authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/mlx5: Check for ERR_PTR from uverbs_zalloc() 

The return code from uverbs_zalloc() was wrongly checked, it is ERR_PTR
not NULL like other allocators:

drivers/infiniband/hw/mlx5/devx.c:2110 devx_umem_reg_cmd_alloc() warn: passing zero to 'PTR_ERR'

Fixes: 878f7b31 ("RDMA/mlx5: Use ib_umem_find_best_pgsz() for devx")
Link: https://lore.kernel.org/r/0-v1-4d05ccc1c223+173-devx_err_ptr_jgg@nvidia.com


Reported-by: default avatarkernel test robot <lkp@intel.com>
Acked-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 66d86e52

drivers/infiniband/hw/mlx5/devx.c

+1 −1
Original line number Diff line number Diff line
@@ -2106,7 +2106,7 @@ static int devx_umem_reg_cmd_alloc(struct mlx5_ib_dev *dev, 
		     (MLX5_ST_SZ_BYTES(mtt) *

		      ib_umem_num_dma_blocks(obj->umem, page_size));

	cmd->in = uverbs_zalloc(attrs, cmd->inlen);

	if (!cmd->in)

	if (IS_ERR(cmd->in))

		return PTR_ERR(cmd->in);



	umem = MLX5_ADDR_OF(create_umem_in, cmd->in, umem);