Commit d47e983e authored by Qing Wang's avatar Qing Wang Committed by Rafael J. Wysocki
Browse files

ACPI: replace snprintf() in "show" functions with sysfs_emit() 



coccicheck complains about the use of snprintf() in sysfs "show"
functions:

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

so use sysfs_emit() instead of it where applicable.

Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5771e582

drivers/acpi/acpi_lpss.c

+1 −1
Original line number Diff line number Diff line
@@ -750,7 +750,7 @@ static ssize_t lpss_ltr_show(struct device *dev, struct device_attribute *attr, 
	if (ret)

		return ret;



	return snprintf(buf, PAGE_SIZE, "%08x\n", ltr_value);

	return sysfs_emit(buf, "%08x\n", ltr_value);

}



static ssize_t lpss_ltr_mode_show(struct device *dev,

drivers/acpi/dock.c

+4 −4
Original line number Diff line number Diff line
@@ -492,7 +492,7 @@ static ssize_t docked_show(struct device *dev, 
	struct acpi_device *adev = NULL;



	acpi_bus_get_device(dock_station->handle, &adev);

	return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev));

	return sysfs_emit(buf, "%u\n", acpi_device_enumerated(adev));

}

static DEVICE_ATTR_RO(docked);
@@ -504,7 +504,7 @@ static ssize_t flags_show(struct device *dev, 
{

	struct dock_station *dock_station = dev->platform_data;



	return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);

	return sysfs_emit(buf, "%d\n", dock_station->flags);



}

static DEVICE_ATTR_RO(flags);
@@ -543,7 +543,7 @@ static ssize_t uid_show(struct device *dev, 
	if (ACPI_FAILURE(status))

		return 0;



	return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);

	return sysfs_emit(buf, "%llx\n", lbuf);

}

static DEVICE_ATTR_RO(uid);
@@ -562,7 +562,7 @@ static ssize_t type_show(struct device *dev, 
	else

		type = "unknown";



	return snprintf(buf, PAGE_SIZE, "%s\n", type);

	return sysfs_emit(buf, "%s\n", type);

}

static DEVICE_ATTR_RO(type);