Commit d3fa0058 authored by Benjamin Gaignard's avatar Benjamin Gaignard Committed by Zeng Heng
Browse files

media: usbtv: Remove useless locks in usbtv_video_free()

mainline inclusion
from mainline-v6.9-rc1
commit 65e6a2773d655172143cc0b927cdc89549842895
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9L9JS
CVE: CVE-2024-27072

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=65e6a2773d655172143cc0b927cdc89549842895

--------------------------------

Remove locks calls in usbtv_video_free() because
are useless and may led to a deadlock as reported here:
https://syzkaller.appspot.com/x/bisect.txt?x=166dc872180000


Also remove usbtv_stop() call since it will be called when
unregistering the device.

Before 'c838530d230b' this issue would only be noticed if you
disconnect while streaming and now it is noticeable even when
disconnecting while not streaming.

Fixes: c838530d230b ("media: media videobuf2: Be more flexible on the number of queue stored buffers")
Fixes: f3d27f34 ("[media] usbtv: Add driver for Fushicai USBTV007 video frame grabber")

Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Tested-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: fix minor spelling mistake in log message]
Conflicts:
	drivers/media/usb/usbtv/usbtv-video.c
[The version does not include commit 24b5836d.]
Signed-off-by: default avatarZeng Heng <zengheng4@huawei.com>
parent 7d91c9c7
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment