Unverified Commit cc587b7c authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: codecs: wc938x: fix accessing array out of bounds for enum type 



Accessing enums using integer would result in array out of bounds access
on platforms like aarch64 where sizeof(long) is 8 compared to enum size
which is 4 bytes.

Fix this by using enumerated items instead of integers.

Fixes: e8ba1e05 ("ASoC: codecs: wcd938x: add basic controls")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220222183212.11580-7-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0ea5eff7

sound/soc/codecs/wcd938x.c

+2 −2
Original line number Diff line number Diff line
@@ -2504,7 +2504,7 @@ static int wcd938x_tx_mode_get(struct snd_kcontrol *kcontrol, 
	struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;

	int path = e->shift_l;



	ucontrol->value.integer.value[0] = wcd938x->tx_mode[path];

	ucontrol->value.enumerated.item[0] = wcd938x->tx_mode[path];



	return 0;

}
@@ -2528,7 +2528,7 @@ static int wcd938x_rx_hph_mode_get(struct snd_kcontrol *kcontrol, 
	struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);

	struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component);



	ucontrol->value.integer.value[0] = wcd938x->hph_mode;

	ucontrol->value.enumerated.item[0] = wcd938x->hph_mode;



	return 0;

}