Unverified Commit 0ea5eff7 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: codecs: va-macro: fix accessing array out of bounds for enum type 



Accessing enums using integer would result in array out of bounds access
on platforms like aarch64 where sizeof(long) is 8 compared to enum size
which is 4 bytes.

Fixes: 908e6b1d ("ASoC: codecs: lpass-va-macro: Add support to VA Macro")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220222183212.11580-5-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bcfe5f76

sound/soc/codecs/lpass-va-macro.c

+2 −2
Original line number Diff line number Diff line
@@ -780,7 +780,7 @@ static int va_macro_dec_mode_get(struct snd_kcontrol *kcontrol, 
	struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;

	int path = e->shift_l;



	ucontrol->value.integer.value[0] = va->dec_mode[path];

	ucontrol->value.enumerated.item[0] = va->dec_mode[path];



	return 0;

}
@@ -789,7 +789,7 @@ static int va_macro_dec_mode_put(struct snd_kcontrol *kcontrol, 
				 struct snd_ctl_elem_value *ucontrol)

{

	struct snd_soc_component *comp = snd_soc_kcontrol_component(kcontrol);

	int value = ucontrol->value.integer.value[0];

	int value = ucontrol->value.enumerated.item[0];

	struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;

	int path = e->shift_l;

	struct va_macro *va = snd_soc_component_get_drvdata(comp);