Commit cc141c35 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: tca6416-keypad - fix interrupt enable disbalance 

The driver has been switched to use IRQF_NO_AUTOEN, but in the error
unwinding and remove paths calls to enable_irq() were left in place, which
will lead to an incorrect enable counter value.

Fixes: bcd9730a ("Input: move to use request_irq by IRQF_NO_AUTOEN flag")
Link: https://lore.kernel.org/r/20230724053024.352054-3-dmitry.torokhov@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent d3176b29

drivers/input/keyboard/tca6416-keypad.c

+2 −6
Original line number Diff line number Diff line
@@ -291,10 +291,8 @@ static int tca6416_keypad_probe(struct i2c_client *client) 
	return 0;



fail2:

	if (!chip->use_polling) {

	if (!chip->use_polling)

		free_irq(client->irq, chip);

		enable_irq(client->irq);

	}

fail1:

	input_free_device(input);

	kfree(chip);
@@ -305,10 +303,8 @@ static void tca6416_keypad_remove(struct i2c_client *client) 
{

	struct tca6416_keypad_chip *chip = i2c_get_clientdata(client);



	if (!chip->use_polling) {

	if (!chip->use_polling)

		free_irq(client->irq, chip);

		enable_irq(client->irq);

	}



	input_unregister_device(chip->input);

	kfree(chip);