Commit bcd9730a authored by Barry Song's avatar Barry Song Committed by Dmitry Torokhov
Browse files

Input: move to use request_irq by IRQF_NO_AUTOEN flag 



disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

On the other hand, request_irq() after setting IRQ_NOAUTOEN as
below
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
can also be replaced by request_irq() with IRQF_NO_AUTOEN flag.

Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20210302224916.13980-3-song.bao.hua@hisilicon.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 73cdf82a

drivers/input/keyboard/tca6416-keypad.c

+1 −2
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ static int tca6416_keypad_probe(struct i2c_client *client, 
		error = request_threaded_irq(chip->irqnum, NULL,

					     tca6416_keys_isr,

					     IRQF_TRIGGER_FALLING |

						IRQF_ONESHOT,

					     IRQF_ONESHOT | IRQF_NO_AUTOEN,

					     "tca6416-keypad", chip);

		if (error) {

			dev_dbg(&client->dev,
@@ -282,7 +282,6 @@ static int tca6416_keypad_probe(struct i2c_client *client, 
				chip->irqnum, error);

			goto fail1;

		}

		disable_irq(chip->irqnum);

	}



	error = input_register_device(input);

drivers/input/keyboard/tegra-kbc.c

+2 −3
Original line number Diff line number Diff line
@@ -694,14 +694,13 @@ static int tegra_kbc_probe(struct platform_device *pdev) 
	input_set_drvdata(kbc->idev, kbc);



	err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr,

			       IRQF_TRIGGER_HIGH, pdev->name, kbc);

			       IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,

			       pdev->name, kbc);

	if (err) {

		dev_err(&pdev->dev, "failed to request keyboard IRQ\n");

		return err;

	}



	disable_irq(kbc->irq);



	err = input_register_device(kbc->idev);

	if (err) {

		dev_err(&pdev->dev, "failed to register input device\n");

drivers/input/touchscreen/ar1021_i2c.c

+1 −4
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, 


	error = devm_request_threaded_irq(&client->dev, client->irq,

					  NULL, ar1021_i2c_irq,

					  IRQF_ONESHOT,

					  IRQF_ONESHOT | IRQF_NO_AUTOEN,

					  "ar1021_i2c", ar1021);

	if (error) {

		dev_err(&client->dev,
@@ -133,9 +133,6 @@ static int ar1021_i2c_probe(struct i2c_client *client, 
		return error;

	}



	/* Disable the IRQ, we'll enable it in ar1021_i2c_open() */

	disable_irq(client->irq);



	error = input_register_device(ar1021->input);

	if (error) {

		dev_err(&client->dev,

drivers/input/touchscreen/atmel_mxt_ts.c

+2 −3
Original line number Diff line number Diff line
@@ -3215,15 +3215,14 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) 
	}



	error = devm_request_threaded_irq(&client->dev, client->irq,

					  NULL, mxt_interrupt, IRQF_ONESHOT,

					  NULL, mxt_interrupt,

					  IRQF_ONESHOT | IRQF_NO_AUTOEN,

					  client->name, data);

	if (error) {

		dev_err(&client->dev, "Failed to register interrupt\n");

		return error;

	}



	disable_irq(client->irq);



	error = regulator_bulk_enable(ARRAY_SIZE(data->regulators),

				      data->regulators);

	if (error) {

drivers/input/touchscreen/bu21029_ts.c

+2 −2
Original line number Diff line number Diff line
@@ -401,10 +401,10 @@ static int bu21029_probe(struct i2c_client *client, 


	input_set_drvdata(in_dev, bu21029);



	irq_set_status_flags(client->irq, IRQ_NOAUTOEN);

	error = devm_request_threaded_irq(&client->dev, client->irq,

					  NULL, bu21029_touch_soft_irq,

					  IRQF_ONESHOT, DRIVER_NAME, bu21029);

					  IRQF_ONESHOT | IRQF_NO_AUTOEN,

					  DRIVER_NAME, bu21029);

	if (error) {

		dev_err(&client->dev,

			"unable to request touch irq: %d\n", error);