Commit cc12a6f2 authored by Ye Bin's avatar Ye Bin Committed by Theodore Ts'o
Browse files

ext4: allocate extended attribute value in vmalloc area 



Now, extended attribute value maximum length is 64K. The memory
requested here does not need continuous physical addresses, so it is
appropriate to use kvmalloc to request memory. At the same time, it
can also cope with the situation that the extended attribute will
become longer in the future.

Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221208023233.1231330-3-yebin@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
parent 8994d113

fs/ext4/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -2548,7 +2548,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode, 


	is = kzalloc(sizeof(struct ext4_xattr_ibody_find), GFP_NOFS);

	bs = kzalloc(sizeof(struct ext4_xattr_block_find), GFP_NOFS);

	buffer = kmalloc(value_size, GFP_NOFS);

	buffer = kvmalloc(value_size, GFP_NOFS);

	b_entry_name = kmalloc(entry->e_name_len + 1, GFP_NOFS);

	if (!is || !bs || !buffer || !b_entry_name) {

		error = -ENOMEM;
@@ -2600,7 +2600,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode, 
	error = 0;

out:

	kfree(b_entry_name);

	kfree(buffer);

	kvfree(buffer);

	if (is)

		brelse(is->iloc.bh);

	if (bs)