Commit 8994d113 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: avoid unaccounted block allocation when expanding inode 



When expanding inode space in ext4_expand_extra_isize_ea() we may need
to allocate external xattr block. If quota is not initialized for the
inode, the block allocation will not be accounted into quota usage. Make
sure the quota is initialized before we try to expand inode space.

Reported-by: default avatarPengfei Xu <pengfei.xu@intel.com>
Link: https://lore.kernel.org/all/Y5BT+k6xWqthZc1P@xpf.sh.intel.com


Signed-off-by: default avatarJan Kara <jack@suse.cz>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20221207115937.26601-2-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 1485f726

fs/ext4/inode.c

+8 −0
Original line number Diff line number Diff line
@@ -5945,6 +5945,14 @@ static int __ext4_expand_extra_isize(struct inode *inode, 
		return 0;

	}



	/*

	 * We may need to allocate external xattr block so we need quotas

	 * initialized. Here we can be called with various locks held so we

	 * cannot affort to initialize quotas ourselves. So just bail.

	 */

	if (dquot_initialize_needed(inode))

		return -EAGAIN;



	/* try to expand with EAs present */

	error = ext4_expand_extra_isize_ea(inode, new_extra_isize,

					   raw_inode, handle);