Commit ca3d9fee authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Doug Ledford
Browse files

IB/rxe: change the function to void from int 



The function rxe_av_from_attr always return 0. So change the
function to void.

CC: Srinivas Eeda <srinivas.eeda@oracle.com>
CC: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 1a241db1

drivers/infiniband/sw/rxe/rxe_av.c

+1 −2
Original line number Diff line number Diff line
@@ -52,14 +52,13 @@ int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr) 
	return 0;

}



int rxe_av_from_attr(u8 port_num, struct rxe_av *av,

void rxe_av_from_attr(u8 port_num, struct rxe_av *av,

		     struct rdma_ah_attr *attr)

{

	memset(av, 0, sizeof(*av));

	memcpy(&av->grh, rdma_ah_read_grh(attr),

	       sizeof(*rdma_ah_read_grh(attr)));

	av->port_num = port_num;

	return 0;

}



int rxe_av_to_attr(struct rxe_dev *rxe, struct rxe_av *av,

drivers/infiniband/sw/rxe/rxe_loc.h

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 


int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr);



int rxe_av_from_attr(u8 port_num, struct rxe_av *av,

void rxe_av_from_attr(u8 port_num, struct rxe_av *av,

		     struct rdma_ah_attr *attr);



int rxe_av_to_attr(struct rxe_dev *rxe, struct rxe_av *av,

drivers/infiniband/sw/rxe/rxe_verbs.c

+2 −3
Original line number Diff line number Diff line
@@ -271,8 +271,7 @@ static int rxe_init_av(struct rxe_dev *rxe, struct rdma_ah_attr *attr, 
		return err;

	}



	err = rxe_av_from_attr(rdma_ah_get_port_num(attr), av, attr);

	if (!err)

	rxe_av_from_attr(rdma_ah_get_port_num(attr), av, attr);

	err = rxe_av_fill_ip_info(rxe, av, attr, &sgid_attr, &sgid);



	if (sgid_attr.ndev)