Commit 1a241db1 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Doug Ledford
Browse files

IB/rxe: remove redudant parameter in function 



In the function rxe_av_from_attr, the parameter rxe
is not used. So it is removed.

CC: Srinivas Eeda <srinivas.eeda@oracle.com>
CC: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 074b5abb

drivers/infiniband/sw/rxe/rxe_av.c

+2 −2
Original line number Diff line number Diff line
@@ -52,8 +52,8 @@ int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr) 
	return 0;

}



int rxe_av_from_attr(struct rxe_dev *rxe, u8 port_num,

		     struct rxe_av *av, struct rdma_ah_attr *attr)

int rxe_av_from_attr(u8 port_num, struct rxe_av *av,

		     struct rdma_ah_attr *attr)

{

	memset(av, 0, sizeof(*av));

	memcpy(&av->grh, rdma_ah_read_grh(attr),

drivers/infiniband/sw/rxe/rxe_loc.h

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ 


int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr);



int rxe_av_from_attr(struct rxe_dev *rxe, u8 port_num,

		     struct rxe_av *av, struct rdma_ah_attr *attr);

int rxe_av_from_attr(u8 port_num, struct rxe_av *av,

		     struct rdma_ah_attr *attr);



int rxe_av_to_attr(struct rxe_dev *rxe, struct rxe_av *av,

		   struct rdma_ah_attr *attr);

drivers/infiniband/sw/rxe/rxe_qp.c

+2 −3
Original line number Diff line number Diff line
@@ -633,8 +633,7 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask, 
		ib_get_cached_gid(&rxe->ib_dev, 1,

				  rdma_ah_read_grh(&attr->ah_attr)->sgid_index,

				  &sgid, &sgid_attr);

		rxe_av_from_attr(rxe, attr->port_num, &qp->pri_av,

				 &attr->ah_attr);

		rxe_av_from_attr(attr->port_num, &qp->pri_av, &attr->ah_attr);

		rxe_av_fill_ip_info(rxe, &qp->pri_av, &attr->ah_attr,

				    &sgid_attr, &sgid);

		if (sgid_attr.ndev)
@@ -648,7 +647,7 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask, 
		ib_get_cached_gid(&rxe->ib_dev, 1, sgid_index,

				  &sgid, &sgid_attr);



		rxe_av_from_attr(rxe, attr->alt_port_num, &qp->alt_av,

		rxe_av_from_attr(attr->alt_port_num, &qp->alt_av,

				 &attr->alt_ah_attr);

		rxe_av_fill_ip_info(rxe, &qp->alt_av, &attr->alt_ah_attr,

				    &sgid_attr, &sgid);

drivers/infiniband/sw/rxe/rxe_verbs.c

+1 −1
Original line number Diff line number Diff line
@@ -271,7 +271,7 @@ static int rxe_init_av(struct rxe_dev *rxe, struct rdma_ah_attr *attr, 
		return err;

	}



	err = rxe_av_from_attr(rxe, rdma_ah_get_port_num(attr), av, attr);

	err = rxe_av_from_attr(rdma_ah_get_port_num(attr), av, attr);

	if (!err)

		err = rxe_av_fill_ip_info(rxe, av, attr, &sgid_attr, &sgid);