Commit c699b05c authored Dec 04, 2020 by Arnd Bergmann Committed by Alex Deucher Dec 08, 2020

drm/amdgpu: fw_attestation: fix unused function warning

Without debugfs, the compiler notices one function that is not used at
all:

drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:123:12: error: unused function 'amdgpu_is_fw_attestation_supported' [-Werror,-Wunused-function]

In fact the static const amdgpu_fw_attestation_debugfs_ops structure is
also unused here, but that warning is currently disabled.

Removing the #ifdef check does the right thing and leads to all of this
code to be dropped without warning.

Fixes: 19ae3330 ("drm/amdgpu: added support for psp fw attestation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 048faf27

drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -130,7 +130,6 @@ static int amdgpu_is_fw_attestation_supported(struct amdgpu_device *adev)

		void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
		{
		#if defined(CONFIG_DEBUG_FS)
		if (!amdgpu_is_fw_attestation_supported(adev))
		return;

		@@ -139,5 +138,4 @@ void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
		adev_to_drm(adev)->primary->debugfs_root,
		adev,
		&amdgpu_fw_attestation_debugfs_ops);
		#endif
		}