Commit 048faf27 authored by Simon Ser's avatar Simon Ser Committed by Alex Deucher
Browse files

drm/amd: print error on convert_tiling_flags_to_modifier failure 



If this function fails, it means the tiling flags didn't make sense.
This likely indicates a user-space bug. Log the error alongside with the
provided tiling flags to make debugging easier.

Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Cc: Michel Dänzer <michel@daenzer.net>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ccac8bab

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

+4 −1
Original line number Diff line number Diff line
@@ -901,9 +901,12 @@ int amdgpu_display_framebuffer_init(struct drm_device *dev, 
	if (dev->mode_config.allow_fb_modifiers &&

	    !(rfb->base.flags & DRM_MODE_FB_MODIFIERS)) {

		ret = convert_tiling_flags_to_modifier(rfb);

		if (ret)

		if (ret) {

			drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier",

				    rfb->tiling_flags);

			goto fail;

		}

	}



	for (i = 1; i < rfb->base.format->num_planes; ++i) {

		rfb->base.obj[i] = rfb->base.obj[0];