Commit c4b6e934 authored by Aleksander Jan Bajkowski's avatar Aleksander Jan Bajkowski Committed by Jakub Kicinski
Browse files

net: lantiq_xrx200: fix lock under memory pressure 



When the xrx200_hw_receive() function returns -ENOMEM, the NAPI poll
function immediately returns an error.
This is incorrect for two reasons:
* the function terminates without enabling interrupts or scheduling NAPI,
* the error code (-ENOMEM) is returned instead of the number of received
packets.

After the first memory allocation failure occurs, packet reception is
locked due to disabled interrupts from DMA..

Fixes: fe1a5642 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
Signed-off-by: default avatarAleksander Jan Bajkowski <olek2@wp.pl>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c8b04370

drivers/net/ethernet/lantiq_xrx200.c

+1 −1
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ static int xrx200_poll_rx(struct napi_struct *napi, int budget) 
			if (ret == XRX200_DMA_PACKET_IN_PROGRESS)

				continue;

			if (ret != XRX200_DMA_PACKET_COMPLETE)

				return ret;

				break;

			rx++;

		} else {

			break;