Commit c8b04370 authored by Aleksander Jan Bajkowski's avatar Aleksander Jan Bajkowski Committed by Jakub Kicinski
Browse files

net: lantiq_xrx200: confirm skb is allocated before using 



xrx200_hw_receive() assumes build_skb() always works and goes straight
to skb_reserve(). However, build_skb() can fail under memory pressure.

Add a check in case build_skb() failed to allocate and return NULL.

Fixes: e0155935 ("net: lantiq_xrx200: convert to build_skb")
Reported-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarAleksander Jan Bajkowski <olek2@wp.pl>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a3a57bf0

drivers/net/ethernet/lantiq_xrx200.c

+6 −0
Original line number Diff line number Diff line
@@ -239,6 +239,12 @@ static int xrx200_hw_receive(struct xrx200_chan *ch) 
	}



	skb = build_skb(buf, priv->rx_skb_size);

	if (!skb) {

		skb_free_frag(buf);

		net_dev->stats.rx_dropped++;

		return -ENOMEM;

	}



	skb_reserve(skb, NET_SKB_PAD);

	skb_put(skb, len);