Commit c475862d authored by Junxian Huang's avatar Junxian Huang Committed by ZhouJuan
Browse files

RDMA/hns: Remove unnecessary QP type checks 

mainline inclusion
from mainline-v6.5-rc1
commit b9989ab3
category: cleanup
bugzilla: https://gitee.com/openeuler/kernel/issues/I7MIUU
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b9989ab3f61ec459cbaf0a492fea3168bbfa4c7a

----------------------------------------------------------------------

It is not necessary to check the type of the queue on IO path because
unsupported QP type cannot be created.

Link: https://lore.kernel.org/r/20230523121641.3132102-2-huangjunxian6@hisilicon.com


Signed-off-by: default avatarChengchang Tang <tangchengchang@huawei.com>
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarJuan Zhou <zhoujuan51@h-partners.com>
parent 7a13eafd

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+3 −19
Original line number Diff line number Diff line
@@ -447,16 +447,9 @@ static int check_send_valid(struct hns_roce_dev *hr_dev, 
			    struct hns_roce_qp *hr_qp)

{

	struct ib_device *ibdev = &hr_dev->ib_dev;

	struct ib_qp *ibqp = &hr_qp->ibqp;

	int ret;



	if (unlikely(ibqp->qp_type != IB_QPT_RC &&

		     ibqp->qp_type != IB_QPT_GSI &&

		     ibqp->qp_type != IB_QPT_UD)) {

		ibdev_err(ibdev, "Not supported QP(0x%x)type!\n",

			  ibqp->qp_type);

		return -EOPNOTSUPP;

	} else if (unlikely(hr_qp->state == IB_QPS_RESET ||

	if (unlikely(hr_qp->state == IB_QPS_RESET ||

		     hr_qp->state == IB_QPS_INIT ||

		     hr_qp->state == IB_QPS_RTR)) {

		ibdev_err(ibdev, "failed to post WQE, QP state %u!\n",
@@ -879,17 +872,8 @@ static int check_recv_valid(struct hns_roce_dev *hr_dev, 
			    struct hns_roce_qp *hr_qp)

{

	struct ib_device *ibdev = &hr_dev->ib_dev;

	struct ib_qp *ibqp = &hr_qp->ibqp;

	int ret;



	if (unlikely(ibqp->qp_type != IB_QPT_RC &&

		     ibqp->qp_type != IB_QPT_GSI &&

		     ibqp->qp_type != IB_QPT_UD)) {

		ibdev_err(ibdev, "unsupported qp type, qp_type = %d.\n",

			  ibqp->qp_type);

		return -EOPNOTSUPP;

	}



	if (unlikely(hr_dev->state >= HNS_ROCE_DEVICE_STATE_RST_DOWN))

		return -EIO;