Commit c2d2f988 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller
Browse files

devlink: Delete not-used single parameter notification APIs 



There is no need in specific devlink_param_*publish(), because same
output can be achieved by using devlink_params_*publish() in correct
places.

Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e9310aed

include/net/devlink.h

+0 −4
Original line number Diff line number Diff line
@@ -1653,10 +1653,6 @@ void devlink_param_unregister(struct devlink *devlink, 
			      const struct devlink_param *param);

void devlink_params_publish(struct devlink *devlink);

void devlink_params_unpublish(struct devlink *devlink);

void devlink_param_publish(struct devlink *devlink,

			   const struct devlink_param *param);

void devlink_param_unpublish(struct devlink *devlink,

			     const struct devlink_param *param);

int devlink_port_params_register(struct devlink_port *devlink_port,

				 const struct devlink_param *params,

				 size_t params_count);

net/core/devlink.c

+0 −48
Original line number Diff line number Diff line
@@ -10121,54 +10121,6 @@ void devlink_params_unpublish(struct devlink *devlink) 
}

EXPORT_SYMBOL_GPL(devlink_params_unpublish);



/**

 * devlink_param_publish - publish one configuration parameter

 *

 * @devlink: devlink

 * @param: one configuration parameter

 *

 * Publish previously registered configuration parameter.

 */

void devlink_param_publish(struct devlink *devlink,

			   const struct devlink_param *param)

{

	struct devlink_param_item *param_item;



	list_for_each_entry(param_item, &devlink->param_list, list) {

		if (param_item->param != param || param_item->published)

			continue;

		param_item->published = true;

		devlink_param_notify(devlink, 0, param_item,

				     DEVLINK_CMD_PARAM_NEW);

		break;

	}

}

EXPORT_SYMBOL_GPL(devlink_param_publish);



/**

 * devlink_param_unpublish - unpublish one configuration parameter

 *

 * @devlink: devlink

 * @param: one configuration parameter

 *

 * Unpublish previously registered configuration parameter.

 */

void devlink_param_unpublish(struct devlink *devlink,

			     const struct devlink_param *param)

{

	struct devlink_param_item *param_item;



	list_for_each_entry(param_item, &devlink->param_list, list) {

		if (param_item->param != param || !param_item->published)

			continue;

		param_item->published = false;

		devlink_param_notify(devlink, 0, param_item,

				     DEVLINK_CMD_PARAM_DEL);

		break;

	}

}

EXPORT_SYMBOL_GPL(devlink_param_unpublish);



/**

 *	devlink_port_params_register - register port configuration parameters

 *