Commit e9310aed authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller
Browse files

net/mlx5: Publish and unpublish all devlink parameters at once 



The devlink parameters were published in two steps despite being static
and known in advance.

First step was to use devlink_params_publish() which iterated over all
known up to that point parameters and sent notification messages.
In second step, the call was devlink_param_publish() that looped over
same parameters list and sent notification for new parameters.

In order to simplify the API, move devlink_params_publish() to be called
when all parameters were already added and save the need to iterate over
parameters list again.

As a side effect, this change fixes the error unwind flow in which
parameters were not marked as unpublished.

Fixes: 82e6c96f ("net/mlx5: Register to devlink ingress VLAN filter trap")
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dc50b930

drivers/net/ethernet/mellanox/mlx5/core/devlink.c

+2 −8
Original line number Diff line number Diff line
@@ -625,7 +625,6 @@ static int mlx5_devlink_eth_param_register(struct devlink *devlink) 
	devlink_param_driverinit_value_set(devlink,

					   DEVLINK_PARAM_GENERIC_ID_ENABLE_ETH,

					   value);

	devlink_param_publish(devlink, &enable_eth_param);

	return 0;

}
@@ -636,7 +635,6 @@ static void mlx5_devlink_eth_param_unregister(struct devlink *devlink) 
	if (!mlx5_eth_supported(dev))

		return;



	devlink_param_unpublish(devlink, &enable_eth_param);

	devlink_param_unregister(devlink, &enable_eth_param);

}
@@ -673,7 +671,6 @@ static int mlx5_devlink_rdma_param_register(struct devlink *devlink) 
	devlink_param_driverinit_value_set(devlink,

					   DEVLINK_PARAM_GENERIC_ID_ENABLE_RDMA,

					   value);

	devlink_param_publish(devlink, &enable_rdma_param);

	return 0;

}
@@ -684,7 +681,6 @@ static void mlx5_devlink_rdma_param_unregister(struct devlink *devlink) 
	if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND) || MLX5_ESWITCH_MANAGER(dev))

		return;



	devlink_param_unpublish(devlink, &enable_rdma_param);

	devlink_param_unregister(devlink, &enable_rdma_param);

}
@@ -709,7 +705,6 @@ static int mlx5_devlink_vnet_param_register(struct devlink *devlink) 
	devlink_param_driverinit_value_set(devlink,

					   DEVLINK_PARAM_GENERIC_ID_ENABLE_VNET,

					   value);

	devlink_param_publish(devlink, &enable_rdma_param);

	return 0;

}
@@ -720,7 +715,6 @@ static void mlx5_devlink_vnet_param_unregister(struct devlink *devlink) 
	if (!mlx5_vnet_supported(dev))

		return;



	devlink_param_unpublish(devlink, &enable_vnet_param);

	devlink_param_unregister(devlink, &enable_vnet_param);

}
@@ -811,7 +805,6 @@ int mlx5_devlink_register(struct devlink *devlink) 
	if (err)

		goto params_reg_err;

	mlx5_devlink_set_params_init_values(devlink);

	devlink_params_publish(devlink);



	err = mlx5_devlink_auxdev_params_register(devlink);

	if (err)
@@ -821,6 +814,7 @@ int mlx5_devlink_register(struct devlink *devlink) 
	if (err)

		goto traps_reg_err;



	devlink_params_publish(devlink);

	return 0;



traps_reg_err:
@@ -835,9 +829,9 @@ int mlx5_devlink_register(struct devlink *devlink) 


void mlx5_devlink_unregister(struct devlink *devlink)

{

	devlink_params_unpublish(devlink);

	mlx5_devlink_traps_unregister(devlink);

	mlx5_devlink_auxdev_params_unregister(devlink);

	devlink_params_unpublish(devlink);

	devlink_params_unregister(devlink, mlx5_devlink_params,

				  ARRAY_SIZE(mlx5_devlink_params));

	devlink_unregister(devlink);