Unverified Commit bf6b5ced authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

ASoC: xilinx: xlnx_formatter_pcm: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-170-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 316a6bbf

sound/soc/xilinx/xlnx_formatter_pcm.c

+2 −3
Original line number Diff line number Diff line
@@ -687,7 +687,7 @@ static int xlnx_formatter_pcm_probe(struct platform_device *pdev) 
	return ret;

}



static int xlnx_formatter_pcm_remove(struct platform_device *pdev)

static void xlnx_formatter_pcm_remove(struct platform_device *pdev)

{

	int ret = 0;

	struct xlnx_pcm_drv_data *adata = dev_get_drvdata(&pdev->dev);
@@ -703,7 +703,6 @@ static int xlnx_formatter_pcm_remove(struct platform_device *pdev) 
		dev_err(&pdev->dev, "audio formatter reset failed\n");



	clk_disable_unprepare(adata->axi_clk);

	return 0;

}



static const struct of_device_id xlnx_formatter_pcm_of_match[] = {
@@ -714,7 +713,7 @@ MODULE_DEVICE_TABLE(of, xlnx_formatter_pcm_of_match); 


static struct platform_driver xlnx_formatter_pcm_driver = {

	.probe	= xlnx_formatter_pcm_probe,

	.remove	= xlnx_formatter_pcm_remove,

	.remove_new = xlnx_formatter_pcm_remove,

	.driver	= {

		.name	= DRV_NAME,

		.of_match_table	= xlnx_formatter_pcm_of_match,