Unverified Commit 316a6bbf authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

ASoC: ux500: ux500_msp_dai: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-169-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d2b6d5b8

sound/soc/ux500/ux500_msp_dai.c

+2 −4
Original line number Diff line number Diff line
@@ -791,7 +791,7 @@ static int ux500_msp_drv_probe(struct platform_device *pdev) 
	return ret;

}



static int ux500_msp_drv_remove(struct platform_device *pdev)

static void ux500_msp_drv_remove(struct platform_device *pdev)

{

	struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(&pdev->dev);
@@ -802,8 +802,6 @@ static int ux500_msp_drv_remove(struct platform_device *pdev) 
	prcmu_qos_remove_requirement(PRCMU_QOS_APE_OPP, "ux500_msp_i2s");



	ux500_msp_i2s_cleanup_msp(pdev, drvdata->msp);



	return 0;

}



static const struct of_device_id ux500_msp_i2s_match[] = {
@@ -818,7 +816,7 @@ static struct platform_driver msp_i2s_driver = { 
		.of_match_table = ux500_msp_i2s_match,

	},

	.probe = ux500_msp_drv_probe,

	.remove = ux500_msp_drv_remove,

	.remove_new = ux500_msp_drv_remove,

};

module_platform_driver(msp_i2s_driver);