Commit bd46cd0b authored May 30, 2023 by Claudiu Beznea Committed by Stephen Boyd Jun 16, 2023

clk: ti: clkctrl: check return value of kasprintf()

kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 85204959 ("clk: ti: clkctrl: convert subclocks to use proper names also")
Fixes: 6c309052 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-8-claudiu.beznea@microchip.com

Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent b73ed981

drivers/clk/ti/clkctrl.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -258,6 +258,9 @@ static const char * __init clkctrl_get_clock_name(struct device_node *np,
		if (clkctrl_name && !legacy_naming) {
		clock_name = kasprintf(GFP_KERNEL, "%s-clkctrl:%04x:%d",
		clkctrl_name, offset, index);
		if (!clock_name)
		return NULL;

		strreplace(clock_name, '_', '-');

		return clock_name;
		@@ -586,6 +589,10 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
		if (clkctrl_name) {
		provider->clkdm_name = kasprintf(GFP_KERNEL,
		"%s_clkdm", clkctrl_name);
		if (!provider->clkdm_name) {
		kfree(provider);
		return;
		}
		goto clkdm_found;
		}