Commit b73ed981 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Stephen Boyd
Browse files

clk: keystone: sci-clk: check return value of kasprintf() 



kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: b745c079 ("clk: keystone: Add sci-clk driver support")
Depends-on: 96488c09 ("clk: keystone: sci-clk: cut down the clock name length")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-7-claudiu.beznea@microchip.com


Reviewed-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 267ad94b

drivers/clk/keystone/sci-clk.c

+2 −0
Original line number Diff line number Diff line
@@ -294,6 +294,8 @@ static int _sci_clk_build(struct sci_clk_provider *provider, 


	name = kasprintf(GFP_KERNEL, "clk:%d:%d", sci_clk->dev_id,

			 sci_clk->clk_id);

	if (!name)

		return -ENOMEM;



	init.name = name;