Commit bac59054 authored by YueHaibing's avatar YueHaibing Committed by Takashi Iwai
Browse files

ALSA: gus: Replace unsafe strcpy() with strscpy() 



Fix smatch warning:
sound/isa/gus/gus_main.c:396 snd_gus_check_version() error:
 strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32)

Even if this is not a real bug since the longest length of card->longname
now is 31, replace strcpy() with strscpy() in order to avoid possible
future mistake.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20210514070507.16600-1-yuehaibing@huawei.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e73b4c9e

sound/isa/gus/gus_main.c

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,7 @@ static int snd_gus_check_version(struct snd_gus_card * gus) 
			}

		}

	}

	strcpy(card->shortname, card->longname);

	strscpy(card->shortname, card->longname, sizeof(card->shortname));

	gus->uart_enable = 1;	/* standard GUSes doesn't have midi uart trouble */

	snd_gus_init_control(gus);

	return 0;