Commit e73b4c9e authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Takashi Iwai
Browse files

ALSA: hda: generic: Remove redundant assignment to dac 



Variable dac is set to zero, but this value is never read as it is
overwritten or not used later on, hence it is a redundant assignment
and can be removed.

Clean up the following clang-analyzer warning:

sound/pci/hda/hda_generic.c:1436:4: warning: Value stored to 'dac' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1620904271-76027-1-git-send-email-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d0f5137b

sound/pci/hda/hda_generic.c

+1 −1
Original line number Diff line number Diff line
@@ -1433,7 +1433,7 @@ static int try_assign_dacs(struct hda_codec *codec, int num_outs, 
			path = snd_hda_add_new_path(codec, dac, pin, 0);

		}

		if (!path) {

			dac = dacs[i] = 0;

			dacs[i] = 0;

			badness += bad->no_dac;

		} else {

			/* print_nid_path(codec, "output", path); */