Commit b6bcd1c0 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bjorn Andersson
Browse files

clk: qcom: fix some Kconfig corner cases 



The SM_GCC_8550 symbol and others can only be built for ARM64 or when
compile testing, but it gets selected by other drivers that can also be
built for 32-bit ARCH_QCOM when not compile testing, which results in
a Kconfig warning:

WARNING: unmet direct dependencies detected for SM_GCC_8550
  Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
  Selected by [m]:
  - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
  - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]

Add further 'depends on' statements to tighten this in a way that
avoids the missing dependencies.

Fixes: fd0b5b10 ("clk: qcom: Introduce SM8350 VIDEOCC")
Fixes: 441fe711 ("clk: qcom: videocc-sm8450: Add video clock controller driver for SM8450")
Fixes: f53153a3 ("clk: qcom: videocc-sm8550: Add video clock controller driver for SM8550")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230801105718.3658612-1-arnd@kernel.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 783cb693

drivers/clk/qcom/Kconfig

+4 −0
Original line number Diff line number Diff line
@@ -986,6 +986,7 @@ config SM_GPUCC_8450 


config SM_GPUCC_8550

	tristate "SM8550 Graphics Clock Controller"

	depends on ARM64 || COMPILE_TEST

	select SM_GCC_8550

	help

	  Support for the graphics clock controller on SM8550 devices.
@@ -1022,6 +1023,7 @@ config SM_VIDEOCC_8250 


config SM_VIDEOCC_8350

	tristate "SM8350 Video Clock Controller"

	depends on ARM64 || COMPILE_TEST

	select SM_GCC_8350

	select QCOM_GDSC

	help
@@ -1031,6 +1033,7 @@ config SM_VIDEOCC_8350 


config SM_VIDEOCC_8550

	tristate "SM8550 Video Clock Controller"

	depends on ARM64 || COMPILE_TEST

	select SM_GCC_8550

	select QCOM_GDSC

	help
@@ -1079,6 +1082,7 @@ config CLK_GFM_LPASS_SM8250 


config SM_VIDEOCC_8450

	tristate "SM8450 Video Clock Controller"

	depends on ARM64 || COMPILE_TEST

	select SM_GCC_8450

	select QCOM_GDSC

	help