Commit b6ad6261 authored by Baruch Siach's avatar Baruch Siach Committed by David S. Miller
Browse files

net: mdio-ipq4019: add delay after clock enable 



Experimentation shows that PHY detect might fail when the code attempts
MDIO bus read immediately after clock enable. Add delay to stabilize the
clock before bus access.

PHY detect failure started to show after commit 7590fc6f ("net:
mdio: Demote probed message to debug print") that removed coincidental
delay between clock enable and bus access.

10ms is meant to match the time it take to send the probed message over
UART at 115200 bps. This might be a far overshoot.

Fixes: 23a890d4 ("net: mdio: Add the reset function for IPQ MDIO driver")
Signed-off-by: default avatarBaruch Siach <baruch.siach@siklu.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc20cced

drivers/net/mdio/mdio-ipq4019.c

+5 −1
Original line number Diff line number Diff line
@@ -200,7 +200,11 @@ static int ipq_mdio_reset(struct mii_bus *bus) 
	if (ret)

		return ret;



	return clk_prepare_enable(priv->mdio_clk);

	ret = clk_prepare_enable(priv->mdio_clk);

	if (ret == 0)

		mdelay(10);



	return ret;

}



static int ipq4019_mdio_probe(struct platform_device *pdev)