Commit b6643122 authored by Rohit Sarkar's avatar Rohit Sarkar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: fix boundary condition for n 



Now that snprintf is replaced by scnprintf n >= MAX_WPA_IE_LEN doesn't
make sense as the maximum value n can take is MAX_WPA_IE_LEN.

Signed-off-by: default avatarRohit Sarkar <rohitsarkar5398@gmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20191002170518.GA1688@SARKAR


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8fcbb6b

drivers/staging/rtl8712/rtl871x_ioctl_linux.c

+2 −2
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ static noinline_for_stack char *translate_scan_wpa(struct iw_request_info *info, 
		for (i = 0; i < wpa_len; i++) {

			n += scnprintf(buf + n, MAX_WPA_IE_LEN - n,

						"%02x", wpa_ie[i]);

			if (n >= MAX_WPA_IE_LEN)

			if (n == MAX_WPA_IE_LEN-1)

				break;

		}

		memset(iwe, 0, sizeof(*iwe));
@@ -164,7 +164,7 @@ static noinline_for_stack char *translate_scan_wpa(struct iw_request_info *info, 
		for (i = 0; i < rsn_len; i++) {

			n += scnprintf(buf + n, MAX_WPA_IE_LEN - n,

						"%02x", rsn_ie[i]);

			if (n >= MAX_WPA_IE_LEN)

			if (n == MAX_WPA_IE_LEN-1)

				break;

		}

		memset(iwe, 0, sizeof(*iwe));