Commit b5a93e79 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Fix flow steering egress flow 

The commit mentioned in Fixes line removed the function that was
called to check validity of esp_aes_gcm attribute. Sadly, that
is_valid_esp_aes_gcm() returned success even for specs without
esp_aes_gcm at all.

So the right fix will be to remove whole if () and such fix
the following error observed in smatch too.

   drivers/infiniband/hw/mlx5/fs.c:1126 _create_flow_rule()
   warn: duplicate check 'is_egress' (previous on line 1098)

Fixes: de8bdb47 ("RDMA/mlx5: Drop crypto flow steering API")
Link: https://lore.kernel.org/r/11b31c1f85bc8c8add385529aa3f307c3b383a11.1649842371.git.leonro@nvidia.com


Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 2f917af7

drivers/infiniband/hw/mlx5/fs.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -1095,11 +1095,6 @@ static struct mlx5_ib_flow_handler *_create_flow_rule(struct mlx5_ib_dev *dev, 




	spec->match_criteria_enable = get_match_criteria_enable(spec->match_criteria);

	spec->match_criteria_enable = get_match_criteria_enable(spec->match_criteria);





	if (is_egress) {

		err = -EINVAL;

		goto free;

	}



	if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_COUNT) {

	if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_COUNT) {

		struct mlx5_ib_mcounters *mcounters;

		struct mlx5_ib_mcounters *mcounters;