Commit 2f917af7 authored by Xiao Yang's avatar Xiao Yang Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Generate a completion for unsupported/invalid opcode 

Current rxe_requester() doesn't generate a completion when processing an
unsupported/invalid opcode. If rxe driver doesn't support a new opcode
(e.g. RDMA Atomic Write) and RDMA library supports it, an application
using the new opcode can reproduce this issue. Fix the issue by calling
"goto err;".

Fixes: 8700e3e7 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20220410113513.27537-1-yangx.jy@fujitsu.com


Signed-off-by: default avatarXiao Yang <yangx.jy@fujitsu.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 7bf5323b

drivers/infiniband/sw/rxe/rxe_req.c

+1 −1
Original line number Diff line number Diff line
@@ -659,7 +659,7 @@ int rxe_requester(void *arg) 
	opcode = next_opcode(qp, wqe, wqe->wr.opcode);

	if (unlikely(opcode < 0)) {

		wqe->status = IB_WC_LOC_QP_OP_ERR;

		goto exit;

		goto err;

	}



	mask = rxe_opcode[opcode].mask;