Commit b1d8c84a authored by Cai Huoqing's avatar Cai Huoqing Committed by Helge Deller
Browse files

video: fbdev: s3c-fb: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent a644da2e

drivers/video/fbdev/s3c-fb.c

+5 −6
Original line number Diff line number Diff line
@@ -1392,18 +1392,17 @@ static int s3c_fb_probe(struct platform_device *pdev) 
	spin_lock_init(&sfb->slock);



	sfb->bus_clk = devm_clk_get(dev, "lcd");

	if (IS_ERR(sfb->bus_clk)) {

		dev_err(dev, "failed to get bus clock\n");

		return PTR_ERR(sfb->bus_clk);

	}

	if (IS_ERR(sfb->bus_clk))

		return dev_err_probe(dev, PTR_ERR(sfb->bus_clk),

				     "failed to get bus clock\n");



	clk_prepare_enable(sfb->bus_clk);



	if (!sfb->variant.has_clksel) {

		sfb->lcd_clk = devm_clk_get(dev, "sclk_fimd");

		if (IS_ERR(sfb->lcd_clk)) {

			dev_err(dev, "failed to get lcd clock\n");

			ret = PTR_ERR(sfb->lcd_clk);

			ret = dev_err_probe(dev, PTR_ERR(sfb->lcd_clk),

					    "failed to get lcd clock\n");

			goto err_bus_clk;

		}