Commit a644da2e authored by Cai Huoqing's avatar Cai Huoqing Committed by Helge Deller
Browse files

video: fbdev: ssd1307fb: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 626e021d

drivers/video/fbdev/ssd1307fb.c

+3 −4
Original line number Diff line number Diff line
@@ -658,9 +658,8 @@ static int ssd1307fb_probe(struct i2c_client *client) 


	par->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);

	if (IS_ERR(par->reset)) {

		dev_err(dev, "failed to get reset gpio: %ld\n",

			PTR_ERR(par->reset));

		ret = PTR_ERR(par->reset);

		ret = dev_err_probe(dev, PTR_ERR(par->reset),

				    "failed to get reset gpio\n");

		goto fb_alloc_error;

	}
@@ -670,7 +669,7 @@ static int ssd1307fb_probe(struct i2c_client *client) 
		if (ret == -ENODEV) {

			par->vbat_reg = NULL;

		} else {

			dev_err(dev, "failed to get VBAT regulator: %d\n", ret);

			dev_err_probe(dev, ret, "failed to get VBAT regulator\n");

			goto fb_alloc_error;

		}

	}