Commit ab2dde5e authored by Vincent Guittot's avatar Vincent Guittot Committed by Ingo Molnar
Browse files

sched/fair: Remove unused return of _nohz_idle_balance 



The return of _nohz_idle_balance() is not used anymore so we can remove
it

Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarValentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20210224133007.28644-3-vincent.guittot@linaro.org
parent 0826530d

kernel/sched/fair.c

+1 −9
Original line number Diff line number Diff line
@@ -10354,10 +10354,8 @@ void nohz_balance_enter_idle(int cpu) 
 * Internal function that runs load balance for all idle cpus. The load balance

 * can be a simple update of blocked load or a complete load balance with

 * tasks movement depending of flags.

 * The function returns false if the loop has stopped before running

 * through all idle CPUs.

 */

static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags,

static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,

			       enum cpu_idle_type idle)

{

	/* Earliest time when we have to do rebalance again */
@@ -10367,7 +10365,6 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, 
	int update_next_balance = 0;

	int this_cpu = this_rq->cpu;

	int balance_cpu;

	int ret = false;

	struct rq *rq;



	SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK);
@@ -10447,15 +10444,10 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, 
	WRITE_ONCE(nohz.next_blocked,

		now + msecs_to_jiffies(LOAD_AVG_PERIOD));



	/* The full idle balance loop has been done */

	ret = true;



abort:

	/* There is still blocked load, enable periodic update */

	if (has_blocked_load)

		WRITE_ONCE(nohz.has_blocked, 1);



	return ret;

}



/*